Address issue 90#92
Merged
pbchase merged 8 commits intoctsit:developfrom Feb 18, 2026
Merged
Conversation
This change restores the eval removed in imagemap v1.13.2.
Replace small squares with larger circles. Add replace_small_square_shapes_with_large_circles.R that rewrote the clickable regions.
These parameters can cause issues in Safari on iOS 26.3 if they don't match the PNG dimensions.
Rename fields for readability and consistency. Change FR_REGION from checkbox to radio.
This files comments are no longer relevant.
There was a problem hiding this comment.
Pull request overview
This pull request addresses issues #90 and #91, which reported that the MBODY and FIBROMYALGIA_BODY image maps only allowed a few selections on mobile devices. The solution involves converting small square-shaped clickable areas to larger circles, which appear to provide better touch target sizes for mobile interactions.
Changes:
- Converted rectangle-shaped clickable areas to circles in MBODY and FIBROMYALGIA_BODY maps
- Updated imageMapster.js library to version 1.9.2
- Added R script documenting the conversion process
- Removed developer documentation about eval() removal
- Added example instrument zip file
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| maps/replace_small_square_shapes_with_large_circles.R | R script that converts rectangular map areas to circles with larger hit targets |
| maps/mbody.html | Converted 36 rectangular areas to circles with radius 27 |
| maps/fibromyalgia.html | Converted 19 rectangular areas to circles with radius 38 |
| js/imageMapster.js | Updated to imageMapster library version 1.9.2 (minified) |
| docs/DEVELOPER_README.md | Removed documentation about manual eval() removal process |
| docs/all_maps_Instrument_Example.zip | Added example instrument files (binary) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issues #90 and #91.
The fundamental change is the removal of all width and height parameters in config.json. The other changes are improvements found along the way to that solution