fix(cli): normalize whitespace-only search filters#55
Merged
luca-ctx merged 2 commits intoJul 5, 2026
Conversation
Contributor
|
Added fmt, thanks for this! |
Contributor
Author
Thanks! I missed the cargo fmt. I’ll make sure to run it first next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While looking at the search filters, I noticed that whitespace-only values passed to
--fileand--workspacewere being ignored by the search pipeline, but they still appeared in the JSONfiltersoutput.This normalizes both fields when building
SearchFilters, so the JSON output reflects the filters that are actually applied.Reproduction
Before:
{ "file": " ", "include_subagents": false }After:
Whitespace-only values are normalized away, so the

filefilter is no longer included in the JSON output. The same behavior now applies to--workspace.Testing
--fileand--workspace.