Skip to content

Enable edge-to-edge and fix insets#226

Merged
caleb-bit merged 3 commits intomainfrom
Caleb/edge-to-edge
Apr 15, 2026
Merged

Enable edge-to-edge and fix insets#226
caleb-bit merged 3 commits intomainfrom
Caleb/edge-to-edge

Conversation

@caleb-bit
Copy link
Copy Markdown
Contributor

@caleb-bit caleb-bit commented Apr 14, 2026

Overview

  • Enabled edge-to-edge
  • Fixed incorrect top padding caused by default scaffold padding
  • Use statusBarPadding instead of hardcoded top padding

Summary by CodeRabbit

  • Bug Fixes
    • Improved status bar and system-inset handling across screens for consistent top spacing on different devices.
    • Enhanced soft keyboard behavior so content resizes reliably when the keyboard appears.
    • Enabled edge-to-edge display support for better screen utilization and a more consistent visual layout.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 12038738-3164-4681-8a5e-ec5c7486e1eb

📥 Commits

Reviewing files that changed from the base of the PR and between 1f1c46c and dee70e3.

📒 Files selected for processing (11)
  • app/src/main/java/com/cornellappdev/android/eatery/ui/components/onboarding/OnboardingCarousel.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/components/settings/SwitchOption.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/AboutScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/FavoritesScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/LegalScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/NearestScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/NotificationsHomeScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/NotificationsSettingsScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/PrivacyScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/SettingsScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/SupportScreen.kt
✅ Files skipped from review due to trivial changes (5)
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/SupportScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/components/settings/SwitchOption.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/components/onboarding/OnboardingCarousel.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/PrivacyScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/LegalScreen.kt
🚧 Files skipped from review as they are similar to previous changes (3)
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/NotificationsHomeScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/FavoritesScreen.kt
  • app/src/main/java/com/cornellappdev/android/eatery/ui/screens/NearestScreen.kt

📝 Walkthrough

Walkthrough

Enable edge-to-edge and system-inset aware layouts: add soft-input adjustResize in the manifest, call enableEdgeToEdge in MainActivity, replace fixed top paddings with statusBarsPadding() across many screens, and set explicit empty contentWindowInsets on some Scaffolds.

Changes

Cohort / File(s) Summary
Window & Activity Config
app/src/main/AndroidManifest.xml, app/src/main/java/com/cornellappdev/android/eatery/MainActivity.kt
Added android:windowSoftInputMode="adjustResize" to MainActivity in the manifest; replaced WindowCompat.setDecorFitsSystemWindows(...) with enableEdgeToEdge() in MainActivity.
Scaffold Insets
app/src/main/java/com/cornellappdev/android/eatery/ui/screens/EateryDetailScreen.kt, app/src/main/java/com/cornellappdev/android/eatery/ui/screens/HomeScreen.kt
Set contentWindowInsets = WindowInsets(0, 0, 0, 0) on Scaffold instances to remove default content inset application.
Status Bar Insets (many screens)
app/src/main/java/com/cornellappdev/android/eatery/ui/screens/{AboutScreen, FavoritesScreen, LegalScreen, NearestScreen, NotificationsHomeScreen, NotificationsSettingsScreen, PrivacyScreen, SettingsScreen}.kt
Replaced fixed top paddings with Modifier.statusBarsPadding() (usually via .then(...)) and consolidated horizontal padding to padding(horizontal = ...).
Search Screen Adjustments
app/src/main/java/com/cornellappdev/android/eatery/ui/screens/SearchScreen.kt
Added statusBarsPadding() to stickyHeader modifier; reduced SearchBar top padding from 64.dp to 12.dp.
Minor UI Modifier Cleanups
app/src/main/java/com/cornellappdev/android/eatery/ui/components/onboarding/OnboardingCarousel.kt, app/src/main/java/com/cornellappdev/android/eatery/ui/components/settings/SwitchOption.kt, app/src/main/java/com/cornellappdev/android/eatery/ui/screens/SupportScreen.kt, app/src/main/java/com/cornellappdev/android/eatery/ui/screens/AboutScreen.kt
Simplified padding declarations (use padding(horizontal = ...), removed explicit zero paddings, minor spacing adjustments like star icon horizontal padding).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

ui

Suggested reviewers

  • AndrewCheung360

Poem

🐰 I hopped through paddings, small and bright,
Replaced fixed tops with insets so light.
Edge to edge I bound each view,
Soft keys resize — a cleaner cue.
Hop! The layouts settle just right. ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides a clear overview of the key changes but lacks the required sections from the template (Changes Made, Test Coverage, and others). Expand the description to include Changes Made section detailing file modifications, add Test Coverage documentation, and include other relevant template sections.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely summarizes the main changes: enabling edge-to-edge display and fixing inset padding issues across the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Caleb/edge-to-edge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread app/src/main/java/com/cornellappdev/android/eatery/ui/screens/AboutScreen.kt Outdated
Comment thread app/src/main/java/com/cornellappdev/android/eatery/ui/screens/FavoritesScreen.kt Outdated
Comment thread app/src/main/java/com/cornellappdev/android/eatery/ui/screens/LegalScreen.kt Outdated
Comment thread app/src/main/java/com/cornellappdev/android/eatery/ui/screens/NearestScreen.kt Outdated
Comment thread app/src/main/java/com/cornellappdev/android/eatery/ui/screens/PrivacyScreen.kt Outdated
Comment thread app/src/main/java/com/cornellappdev/android/eatery/ui/screens/SettingsScreen.kt Outdated
Copy link
Copy Markdown
Member

@AndrewCheung360 AndrewCheung360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mainly left nit comments about using horizontal padding

@caleb-bit caleb-bit merged commit 5881958 into main Apr 15, 2026
3 checks passed
@caleb-bit caleb-bit deleted the Caleb/edge-to-edge branch April 15, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants