Fix dark mode visual bugs (stacked on Brian_DarkMode)

[AndrewCheung360]

Overview

Follow-up fixes for the dark mode PR (#222), addressing remaining visual bugs and review comments found during testing.

Changes Made

CompareMenus (CompareMenusScreen.kt)

• Fix tab centering: scrollOffset = -sidePaddingPx was pushing tabs rightward; with symmetric contentPadding = sidePadding, scrollOffset = 0 correctly centers each tab
• All tabs now get accentPrimary background so unselected tabs look like buttons, not plain text

EateryDetailsStickyHeader (EateryDetailsStickyHeader.kt)

• Category pills now correctly highlight the last visible category when scrolled to the bottom of the list (previously stuck on first-visible-only logic)
• Refactored to a single derivedStateOf block; removed the separate highlightCategory composable

FavoritesViewModel (FavoritesViewModel.kt)

• Fix "Available today" logic: use startTimestamp.toLocalDate() == today instead of end-time comparison, preventing past days' events from showing as available
• Normalize raw meal type strings (e.g. Late_night → Late Dinner); flatMap over all matching events per eatery so multiple meal types per location are captured

FavoritesToggle (FavoritesToggle.kt)

• Remove shadow, increase border to 1.dp for cleaner look

ItemFavoritesCard (ItemFavoritesCard.kt)

• Use accentPrimary container color for dark mode contrast
• Long item names truncate with ellipsis instead of pushing star icon off-screen

MenuCard / PaymentWidgets / FilterRow / AccountPage / Color.kt

• MenuCard (Upcoming): accentPrimary background for card contrast in dark mode
• PaymentWidgets: accentPrimary surface color so payment icons don't disappear in dark mode
• FilterRow: fillMaxWidth on LazyRow for proper left-alignment
• AccountPage: oppTextPrimary tint on settings icon for both expanded and collapsed header states (icon was invisible on the blue header in dark mode)
• AccentPrimaryDark: lightened to 0xFF2E2E2E for better card/background contrast

Test Coverage

• TODO

Next Steps (optional)

• Push unpushed commit on Brian_DarkMode and verify CI passes
• Visual QA in both light and dark mode on device

Related PRs or Issues (optional)

Stacked on #222 (Brian dark mode). Closes or partially addresses #244, #245, #246, #247, #248, #249, #250, #251.

Screenshots (optional)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 65a57c7c-e111-4e07-8885-7900eebc35d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch Andrew/DarkModeFixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[caleb-bit]

LGTM