Clean up constants#255
Merged
Merged
Conversation
alanna-zhou
requested review from
aliciaxw,
kq-li,
manishsaha,
meganle and
young-k
young-k
approved these changes
Sep 14, 2019
Contributor
young-k
left a comment
young-k
left a comment
There was a problem hiding this comment.
Probably useful to add even more comments than the initial ones that I suggested (inside of constants.js)
kq-li
approved these changes
Sep 15, 2019
kq-li
approved these changes
Sep 19, 2019
kq-li
reviewed
Sep 20, 2019
| max: 1000, // Max 1000 routes | ||
| maxAge: 1000 * 60 * 15, // Max age in 15 minutes | ||
| }; | ||
| // A cache mapping a /search's request query string to its Google autocomplete predictions |
There was a problem hiding this comment.
this newline spacing is inconsistent with the above change
alanna-zhou
added a commit
that referenced
this pull request
Nov 21, 2019
This reverts commit e266496.
alanna-zhou
added a commit
that referenced
this pull request
Nov 21, 2019
cindy-x-liang
pushed a commit
that referenced
this pull request
Oct 9, 2025
cindy-x-liang
pushed a commit
that referenced
this pull request
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralized all the constants in one file, and removed the postman token because it was useless.
Again, sorry for the duplicate PR--for some reason, using the RETRY_COUNT constant in RequestUtils.js broke everything. Will be deleting the original PR once this gets merged in.
Currently testing on dev server (transit-dev:alanna) because it sometimes works and sometimes doesn't work