Skip to content

Refactor article date handling to use ISO 8601 format #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
claiireyu merged 1 commit into from
Nov 19, 2025
Merged

Refactor article date handling to use ISO 8601 format #45

claiireyu merged 1 commit into from
Nov 19, 2025

Conversation

@claiireyu
Copy link
Contributor

@claiireyu claiireyu commented Nov 17, 2025

Overview

Refactor article date handling to use ISO 8601 format

Changes Made

  • Simplified ArticleType initialization by removing datetime conversion for published_at.
  • Updated CreateArticle mutation to accept published_at directly in ISO 8601 format.
  • Modified ArticleRepository queries to use ISO 8601 strings for date comparisons.
  • Adjusted daily_sun_scrape to handle published_at in UTC and convert to ISO 8601 format.

Test Coverage

Tested locally in GraphQl playground

skyeslattery
skyeslattery approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@skyeslattery skyeslattery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

TushigBili
TushigBili approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@TushigBili TushigBili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@claiireyu claiireyu merged commit aeb28ff into master Nov 19, 2025
3 checks passed
@claiireyu claiireyu deleted the claire/articleVideoTimeFix branch November 19, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TushigBili TushigBili TushigBili approved these changes

@skyeslattery skyeslattery skyeslattery approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@claiireyu @TushigBili @skyeslattery