Skip to content

Conversation

@claiireyu
Copy link
Contributor

Overview

Implement sport type extraction from article titles

Changes Made

  • Added a new helper function extract_sport_type_from_title to determine the sport type based on the article title.
  • Updated the fetch_news function in daily_sun_scrape.py to utilize the new helper function for extracting sport types instead of relying on article tags.

Test Coverage

Tested locally in GraphQL

Copy link
Contributor

@TushigBili TushigBili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@skyeslattery skyeslattery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@claiireyu claiireyu merged commit 8ab9357 into master Nov 19, 2025
3 checks passed
@claiireyu claiireyu deleted the claire/articleSportTypeFix branch November 19, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants