Comment out onboarding feature for Updated Gym Details Release #88
Conversation
…to use secrets.properties
Implements UI for main Reminders menu screen
Tested Report Networking + Navigation and Networking Reorganization
[ONBOARDING] Basic Navigation
Add PR Template
…still need to find fix for muscle icons and popular times networking
…de visual bug TODO
…es bar based on current time of user
…ed todos for those that need fixing
…to profile creation, modified viewmodel dependencies
…nent and added TODOs
…d redundant functions/code, modified reportSubmitScreen to not require viewmodel, updated report vm function call scope
Completed Majority of Onboarding Flow
…ption issue for populartimes, reduced poptimes interval to start-end of open hours
…imes launchedeffect logic to viewmodel
Popular Times Networking
Last fix to Popular Times Networking
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
I appreciate you working on this so we can get out gym details page. But I feel like commenting out tons of code is never the best idea. In industry, there's this concept of a "feature flag", where new features are locked behind these, and the backend is actually what roles out the update. We don't have this on AppDev, but what we can do is, instead of commenting this out, put it behind a boolean flag. This way, if you want to test separately with onboarding enabled or disabled it's much easier. It should also make this PR way shorter (just disable navigation to the onboarding page and any way to get to it!). Lmk if that makes sense.
…m/cuappdev/uplift-android into andrew/remove-google-sign-in-temp
|
Just added a boolean feature flag for onboarding. Let me know if this was what you were envisioning. |
Quick PR for temporarily commenting out onboarding google sign in feature before releasing updated gym details feature.