Implement Group Class Scraper#110
Conversation
…added activity and gym rresolvers to the schema
… and price resolver in Activity class
joycrwu
left a comment
joycrwu
left a comment
There was a problem hiding this comment.
The scraper code looks good, for some of the models in the codebase, have their formatting been changed on purpose or is it just a git formatting thing?
I think its just my linter |
isabellahoie
left a comment
isabellahoie
left a comment
There was a problem hiding this comment.
Everything looks good just my 2 questions !!
| isVirtual = Column(Boolean(), nullable=False, default=False) | ||
| start_time = Column(DateTime(), nullable=False) | ||
| end_time = Column(DateTime(), nullable=False) | ||
| class_ = relationship("Class", back_populates="gyms") |
There was a problem hiding this comment.
I'm confused as to what "class_" is ??
There was a problem hiding this comment.
its a relationship to the Class model, but "class" is a reservedword in python so i had to call it class_
| start_time = Column(DateTime(), nullable=False) | ||
| end_time = Column(DateTime(), nullable=False) | ||
| class_ = relationship("Class", back_populates="gyms") | ||
| gym = relationship("Gym", back_populates="classes") |
There was a problem hiding this comment.
Is this for a many to many relationship or a one to many?
There was a problem hiding this comment.
many classInstances to one gym
There was a problem hiding this comment.
wait so what is the difference between the "gym_id" column and "gym" column
3 participants
Overview
Implemented the scraper for group classes
Changes Made
*Finished the scraper for group classes in
scraper.pyClassInstancemodel, which is an Association table betweenClassesandGymsthat contains information about a scheduled instance of a classTest Coverage
Verified models and data in GraphQL playground and the Sqlite database
Next Steps (delete if not applicable)
Related PRs or Issues (delete if not applicable)
Screenshots (delete if not applicable)
Screen Shot Name