Skip to content

feat(Notifications): rework#1034

Merged
tenphi merged 20 commits intomainfrom
feat-new-notifications
Feb 18, 2026
Merged

feat(Notifications): rework#1034
tenphi merged 20 commits intomainfrom
feat-new-notifications

Conversation

@tenphi
Copy link
Copy Markdown
Member

@tenphi tenphi commented Feb 16, 2026

Note

Medium Risk
Large behavioral refactor of core overlay UX (timers, dismissal semantics, keyboard/ARIA, and persistence) that could introduce regressions in notification/toast display and lifecycle; no authentication or data persistence beyond in-memory state.

Overview
Refactors the overlay messaging system by removing the legacy NewNotifications implementation (bar, dialog, list, view components, provider/hooks, tests, and stories) and replacing it with a new Notifications module backed by a unified OverlayProvider.

Root now mounts OverlayProvider instead of NotificationsProvider + ToastProvider, and the new system introduces a revamped Notification/Notification.Action API plus hooks (useNotifications, usePersistentNotifications, useNotificationsCount) with support for persistent (archived) notifications, stored-only recording, unified toast+notification stacking/positioning, and updated docs/stories/tests for the new behavior.

Written by Cursor Bugbot for commit 183a182. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 16, 2026

🦋 Changeset detected

Latest commit: 183a182

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cube-ui-kit Ready Ready Preview, Comment Feb 18, 2026 4:39pm
cube-ui-kit-cursor Ready Ready Preview, Comment Feb 18, 2026 4:39pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 16, 2026

🧪 Storybook is successfully deployed!

Comment thread src/components/overlays/Notifications/NotificationCard.tsx Outdated
Comment thread src/components/actions/ItemAction/ItemAction.tsx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 16, 2026

📦 NPM canary release

Deployed canary version 0.0.0-canary-f7a0a54.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 16, 2026

🏋️ Size limit report

Name Size Passed?
All 356.5 KB (-1.02% 🔽👏) Yes 🎉
Tree shaking (just a Button) 59.85 KB (0% 🟰) Yes 🎉
Tree shaking (just tasty) 35.76 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

Comment thread src/components/overlays/Notifications/Notification.tsx
Comment thread src/components/overlays/Notifications/OverlayContainer.tsx
Comment thread src/components/overlays/Notifications/NotificationCard.tsx Outdated
Comment thread src/components/overlays/Notifications/use-persistent-state.ts
Comment thread src/components/overlays/Notifications/OverlayContainer.tsx
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread src/components/overlays/Notifications/Notification.tsx
@tenphi tenphi merged commit 10f3e42 into main Feb 18, 2026
17 checks passed
@tenphi tenphi deleted the feat-new-notifications branch February 18, 2026 16:51
@github-actions github-actions Bot mentioned this pull request Feb 18, 2026
tenphi added a commit that referenced this pull request Feb 19, 2026
Conflict resolutions:

1. NewNotifications test files (4 modify/delete conflicts):
   - Bar/__tests__/notifications-bar.test.tsx
   - NotificationView/notification.test.tsx
   - NotificationsList/notification-list.test.tsx
   - notification.test.tsx
   Resolution: Accepted main's deletions. The feat(Notifications): rework commit
   (#1034) intentionally removed the old NewNotifications test structure as part
   of a full architectural rework. The Vitest migrations on this branch for those
   files are superseded by the deletion.

2. Notifications.test.tsx (new file from main):
   The new Notifications.test.tsx introduced by the rework commit still used
   Jest APIs (jest.mock, jest.fn, jest.useFakeTimers, etc.). Updated all
   references to vi.* equivalents to stay consistent with this branch's
   Jest -> Vitest migration.

3. package.json and .size-limit.cjs (auto-merged):
   - package.json: version bumped from 0.113.1 to 0.114.0 (from main)
   - .size-limit.cjs: bundle size limit reduced from 395kB to 370kB (from main)
   Both auto-merged cleanly with no intervention needed.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant