Conversation
🦋 Changeset detectedLatest commit: 183a182 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-f7a0a54. |
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Merged
tenphi
added a commit
that referenced
this pull request
Feb 19, 2026
Conflict resolutions: 1. NewNotifications test files (4 modify/delete conflicts): - Bar/__tests__/notifications-bar.test.tsx - NotificationView/notification.test.tsx - NotificationsList/notification-list.test.tsx - notification.test.tsx Resolution: Accepted main's deletions. The feat(Notifications): rework commit (#1034) intentionally removed the old NewNotifications test structure as part of a full architectural rework. The Vitest migrations on this branch for those files are superseded by the deletion. 2. Notifications.test.tsx (new file from main): The new Notifications.test.tsx introduced by the rework commit still used Jest APIs (jest.mock, jest.fn, jest.useFakeTimers, etc.). Updated all references to vi.* equivalents to stay consistent with this branch's Jest -> Vitest migration. 3. package.json and .size-limit.cjs (auto-merged): - package.json: version bumped from 0.113.1 to 0.114.0 (from main) - .size-limit.cjs: bundle size limit reduced from 395kB to 370kB (from main) Both auto-merged cleanly with no intervention needed. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Large behavioral refactor of core overlay UX (timers, dismissal semantics, keyboard/ARIA, and persistence) that could introduce regressions in notification/toast display and lifecycle; no authentication or data persistence beyond in-memory state.
Overview
Refactors the overlay messaging system by removing the legacy
NewNotificationsimplementation (bar, dialog, list, view components, provider/hooks, tests, and stories) and replacing it with a newNotificationsmodule backed by a unifiedOverlayProvider.Rootnow mountsOverlayProviderinstead ofNotificationsProvider+ToastProvider, and the new system introduces a revampedNotification/Notification.ActionAPI plus hooks (useNotifications,usePersistentNotifications,useNotificationsCount) with support for persistent (archived) notifications, stored-only recording, unified toast+notification stacking/positioning, and updated docs/stories/tests for the new behavior.Written by Cursor Bugbot for commit 183a182. This will update automatically on new commits. Configure here.