Merged
Conversation
Its row-level stopPropagation() on pointer/mouse events prevented document-level listeners from receiving them. Most visibly, Layout.Panel's resize (via React Aria's useMove) latched when the cursor released over a folder row in a Tree rendered inside a resizable panel (e.g. FilesEditor). The default treegrid behavior (chevron expands, row activates selection) is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 71f4d1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-615deed. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
The virtual sizer (`height: totalSize`) was applied directly to the scroll element, so scrolling down made the viewport expand instead of revealing more rows. Move the sizer to an inner wrapper so the outer element stays a stable scroll viewport. Co-authored-by: Cursor <cursoragent@cursor.com>
TreeElement was both a flex layout container and the overflow:auto scroll element, so the virtualizer sizer (a flex child with height: totalSize) was squashed by flex-shrink: 1 and the scroll area visibly grew as react-virtual re-measured rows during scroll. Move overflow/scrollbar onto a new block-level TreeScrollContainer so the sizer's height is honored, and forward the public ref to it for direct scrollTop access. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its row-level stopPropagation() on pointer/mouse events prevented document-level listeners from receiving them. Most visibly, Layout.Panel's resize (via React Aria's useMove) latched when the cursor released over a folder row in a Tree rendered inside a resizable panel (e.g. FilesEditor).
The default treegrid behavior (chevron expands, row activates selection) is unchanged.
Describe changes
Checklist
Before taking this PR from the draft, please, make sure you have done the following:
Closes: N/A
Other information
Note
Medium Risk
Medium risk because it removes the public
expandOnFolderClickprop (behavior/API change) and changes the forwardedreftarget to a new inner scroll element, which may affect consumers relying on previous DOM structure.Overview
Fixes Tree virtualization layout by moving scrolling into a new inner
TreeScrollContainer, preventing the virtualizer sizer from being flex-shrunk and eliminating scroll viewport growth during re-measure.Removes the
expandOnFolderClickprop and all related event-interception logic/tests/docs/stories to restore defaulttreegridrow activation behavior and avoid blocking document-level pointer/mouse listeners.Updates ref-forwarding semantics so the forwarded
refnow points to the inner scroll container (parent remains therole="treegrid"element), and adjusts tests accordingly.Reviewed by Cursor Bugbot for commit 71f4d1f. Bugbot is set up for automated code reviews on this repo. Configure here.