Skip to content

fix(stories): use Space for vertical stacks of inline-level items#1168

Merged
tenphi merged 2 commits into
mainfrom
fix-stories-gaps
May 14, 2026
Merged

fix(stories): use Space for vertical stacks of inline-level items#1168
tenphi merged 2 commits into
mainfrom
fix-stories-gaps

Conversation

@tenphi
Copy link
Copy Markdown
Member

@tenphi tenphi commented May 14, 2026

Replace Flow with Space flow="column" in stories where children are inline-level (ItemButton/Item/Button/Text), so vertical stacking and gap actually apply. Flow stays block-flow as designed.

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: N/A

Other information


Note

Low Risk
Low risk because changes are limited to Storybook layout markup and imports, with no production component logic modified.

Overview
Storybook examples for ItemAction, ItemButton, Menu, Item, ComboBox, FilterPicker, ListBox, TextArea, and Tabs replace Flow wrappers with Space flow="column" (or Space flow="row"/"row wrap") where children are inline-level, ensuring vertical stacking and gap spacing apply as intended.

Also adjusts related story layout details (imports, a few wrapper props, and removing manual margin spacing in TextArea stories in favor of Space gaps).

Reviewed by Cursor Bugbot for commit 653dc73. Bugbot is set up for automated code reviews on this repo. Configure here.

Replace Flow with Space flow="column" in stories where children are
inline-level (ItemButton/Item/Button/Text), so vertical stacking and gap
actually apply. Flow stays block-flow as designed.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cube-ui-kit Ready Ready Preview, Comment May 14, 2026 0:39am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2026

⚠️ No Changeset found

Latest commit: f0a400e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

📦 NPM canary release

Deployed canary version 0.0.0-canary-efb338d.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

🏋️ Size limit report

Name Size Passed?
All 393.38 KB (+0.05% 🔺) Yes 🎉
Tree shaking (just a Button) 112.42 KB (+0.12% 🔺) Yes 🎉

Click here if you want to find out what is changed in this build

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

🧪 Storybook is successfully deployed!

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 653dc73. Configure here.

Comment thread src/components/actions/ItemAction/ItemAction.stories.tsx
@tenphi tenphi merged commit 04ebe23 into main May 14, 2026
15 checks passed
@tenphi tenphi deleted the fix-stories-gaps branch May 14, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant