Skip to content

fix: popovers in ComboBox and Select #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2025
Merged

fix: popovers in ComboBox and Select #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10eeb73
fix: popovers in ComboBox and Select
tenphi Oct 27, 2025
f12054d
chore: prettier
tenphi Oct 27, 2025
200e78a
chore: cleaning
tenphi Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-colts-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Fix position of ComboBox and Select popovers.
18 changes: 9 additions & 9 deletions src/components/fields/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import {
Styles,
tasty,
} from '../../../tasty';
import { chainRaf } from '../../../utils/raf';
import { generateRandomId } from '../../../utils/random';
import {
mergeProps,
Expand Down Expand Up @@ -867,17 +868,16 @@ function ComboBoxOverlay({
popoverRef as any,
);

// Update position when overlay opens
// Update position when overlay opens or content changes
useLayoutEffect(() => {
if (isOpen) {
// Use double RAF to ensure layout is complete before positioning
requestAnimationFrame(() => {
requestAnimationFrame(() => {
updatePosition?.();
});
});
if (isOpen && updatePosition) {
// Use triple RAF to ensure layout is complete before positioning
// This gives enough time for the DisplayTransition and content to render
return chainRaf(() => {
updatePosition();
}, 3);
}
}, [isOpen, updatePosition]);
}, [isOpen]);
Copy link

@cursor cursor bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Overlay Positioning Hook Dependency Issue

The useLayoutEffect for overlay positioning in Select and ComboBox components omits updatePosition from its dependency array. This violates React's rules of hooks, causing a stale closure. As a result, the popover's position might not update correctly if its configuration changes.

Additional Locations (1)

Fix in Cursor Fix in Web


// Extract primary placement direction for consistent styling
const placementDirection = placement?.split(' ')[0] || direction;
Expand Down
297 changes: 0 additions & 297 deletions src/components/fields/LegacyComboBox/LegacyComboBox.docs.mdx
View file
Open in desktop

This file was deleted.

Loading
Loading