-
Notifications
You must be signed in to change notification settings - Fork 6
feat(Item): show actions on hover #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 83e6c1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-84f2450. |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
🧪 Storybook is successfully deployed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: TypeScript: Removed prop still used causing type mismatch
The showActionsOnHover prop was removed from the CubeItemButtonProps interface but is still being used in the component implementation (line 106) and destructured from allProps. This creates a type mismatch where the prop is accepted at runtime but not declared in the TypeScript interface, breaking type safety for consumers.
src/components/actions/ItemButton/ItemButton.tsx#L21-L28
cube-ui-kit/src/components/actions/ItemButton/ItemButton.tsx
Lines 21 to 28 in 63cf53a
| export interface CubeItemButtonProps | |
| extends Omit<CubeItemProps, 'size'>, | |
| Omit<CubeUseActionProps, 'as'> { | |
| actions?: ReactNode; | |
| size?: Omit<CubeItemProps['size'], 'inline'>; | |
| wrapperStyles?: Styles; | |
| } |
Note
Adds Item.showActionsOnHover with non-shifting hover/focus reveals, evaluates FilterPicker renderSummary regardless of selection (incl. icon-only/placeholder cases), introduces Text.Placeholder, and allows form labels to wrap; also disables focus on inline actions and standardizes Storybook testing imports.
src/components/content/Item):showActionsOnHoverprop; actions fade in on hover/focus without layout shift.disableActionsFocusviaItemActionProvider; newdisableActionsFocusprop to prevent tab focus on inline actions.tabIndexand context-drivendisableActionsFocus; applied inMenuItem,ListBox.Item, andSelect.Optionto remove action buttons from tab order.src/components/fields/FilterPicker):renderSummaryregardless of selection;renderSummary={false}and custom renderers now work with no selection.src/components/content/Text):Text.Placeholdervariant (reduced opacity) and export typed subcomponents.src/components/form/Label):data-type="primary"and consolidated fill styles.@storybook/testimports and configure in.storybook/preview.jsx; add@storybook/testdependency.Written by Cursor Bugbot for commit 83e6c1e. This will update automatically on new commits. Configure here.