fix(Layout): nested layouts with resizable panels #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 50d10fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-2cfc177. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes core
Layout/Layout.Panelrendering and context plumbing (including portal-based DOM placement), which can affect panel positioning, resize behavior, and mount timing across the app.Overview
Fixes nested
Layoutusage so panels in child layouts no longer register against or resize the parent layout, by splittingLayoutContextinto actions/state/refs contexts and updatingLayoutContextResetto fully null out nested providers.Switches
Layout.Panelto render via React portals into a newPanelContainercreated byLayout(instead of relying on direct-child heuristics), including a container-ready gate to avoid rendering before the portal target exists; tests are expanded to cover nested layouts, resizable independence, and wrapped/styled panels. A patch changeset is added and new context exports are exposed fromLayout/index.tsx.Written by Cursor Bugbot for commit 50d10fe. This will update automatically on new commits. Configure here.