Skip to content

Conversation

@joacoc
Copy link
Contributor

@joacoc joacoc commented Aug 23, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

There is no reference issue.

Description of Changes Made (if issue reference is not provided)

Newer versions of Materialize have a different way to query the schema.
This PR maintains backward compatibility with older versions too.

Added semver lib to calculate the versions.
Added ramda lib to keep the same mechanism to return the schema as BaseDriver in tablesSchema.

@joacoc joacoc requested a review from a team as a code owner August 23, 2022 19:20
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #5148 (3ef4012) into master (19e7a71) will decrease coverage by 22.96%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5148       +/-   ##
===========================================
- Coverage   82.99%   60.02%   -22.97%     
===========================================
  Files         129      139       +10     
  Lines       19607    11593     -8014     
  Branches        0     2918     +2918     
===========================================
- Hits        16272     6959     -9313     
- Misses       3335     4130      +795     
- Partials        0      504      +504     
Flag Coverage Δ
cube-backend 60.02% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/service.rs
...sql/cubeclient/src/models/v1_load_request_query.rs
...cubesql/cubesql/src/compile/rewrite/rules/dates.rs
...src/models/v1_load_request_query_time_dimension.rs
.../engine/information_schema/postgres/pg_sequence.rs
rust/cubesql/cubesql/src/sql/server_manager.rs
rust/cubesql/cubesql/e2e/main.rs
...st/cubesql/cubesql/src/compile/engine/df/coerce.rs
rust/cubesql/pg-srv/src/lib.rs
rust/cubesql/cubesql/src/compile/parser.rs
... and 258 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@buntarb
Copy link
Contributor

buntarb commented Sep 27, 2022

Hi, @joacoc! Thanks for your contribution. I have reviewed this PR, and it looks straightforward enough. But unfortunately, there were some significant changes (the BaseDriver class was split into an independent package) a while ago, and it contains some conflicts and stuff to fix. So, could you please rebase and fix it?

@joacoc joacoc closed this Oct 3, 2022
@joacoc joacoc force-pushed the materialize-schema-version branch from 3ef4012 to 7ab15c6 Compare October 3, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants