Skip to content

Conversation

@joacoc
Copy link
Contributor

@joacoc joacoc commented Oct 3, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Reference

I had to create another branch due to a local main branch incompatibility (the PR got automatically closed.)
cc. @buntarb

Description of Changes Made (if issue reference is not provided)

Newer versions of Materialize have a different way to query the schema.
This PR maintains backward compatibility with older versions too.

Added semver lib to calculate the versions.
Added ramda lib to keep the same mechanism to return the schema as BaseDriver in tablesSchema.

@joacoc joacoc requested a review from a team as a code owner October 3, 2022 16:35
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 61.14% // Head: 61.14% // No change to project coverage 👍

Coverage data is based on head (c0dcf41) compared to base (7ab15c6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5407   +/-   ##
=======================================
  Coverage   61.14%   61.14%           
=======================================
  Files         140      140           
  Lines       11985    11985           
  Branches     2933     2933           
=======================================
  Hits         7328     7328           
  Misses       4367     4367           
  Partials      290      290           
Flag Coverage Δ
cube-backend 61.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buntarb buntarb self-requested a review October 5, 2022 13:51
@buntarb buntarb self-assigned this Oct 5, 2022
@buntarb
Copy link
Contributor

buntarb commented Oct 5, 2022

Hi, @joacoc! Thanks for the updates.

@buntarb buntarb merged commit 531e0ad into cube-js:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants