Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Nov 27, 2025

We don't need to cache them or mark as used in cache store, because it's single tables. Caching such keys result in huge memory usage, we can call it as memory leak.

@ovr ovr marked this pull request as ready for review November 27, 2025 13:52
@ovr ovr requested a review from a team as a code owner November 27, 2025 13:52
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.57%. Comparing base (2986f19) to head (433f273).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...y-orchestrator/src/orchestrator/PreAggregations.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10192      +/-   ##
==========================================
- Coverage   54.57%   54.57%   -0.01%     
==========================================
  Files         217      217              
  Lines       17018    17019       +1     
  Branches     3475     3476       +1     
==========================================
  Hits         9288     9288              
- Misses       7229     7230       +1     
  Partials      501      501              
Flag Coverage Δ
cube-backend 54.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Cool!

@ovr ovr merged commit 53d79bb into master Nov 27, 2025
71 of 73 checks passed
@ovr ovr deleted the fix/table-used-large-keys branch November 27, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants