fix(api-gateway): Remove Transfer-Encoding header on /cubesql error r…#10455
Merged
fix(api-gateway): Remove Transfer-Encoding header on /cubesql error r…#10455
Conversation
…esponses, fix #10450 The /cubejs-api/v1/cubesql endpoint sets Transfer-Encoding: chunked for streaming responses. When an error occurs before streaming begins, the error handler calls res.json() which adds Content-Length. Having both headers violates RFC 9112 and causes Node.js 22+ fetch() to reject with HPE_UNEXPECTED_CONTENT_LENGTH. Remove the Transfer-Encoding header in the catch block before sending the JSON error response.
waralexrom
approved these changes
Mar 3, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10455 +/- ##
==========================================
- Coverage 57.64% 57.64% -0.01%
==========================================
Files 222 222
Lines 17393 17394 +1
Branches 3562 3562
==========================================
Hits 10027 10027
- Misses 6828 6829 +1
Partials 538 538
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…esponses, fix #10450
The /cubejs-api/v1/cubesql endpoint sets Transfer-Encoding: chunked for streaming responses. When an error occurs before streaming begins, the error handler calls res.json() which adds Content-Length. Having both headers violates RFC 9112 and causes Node.js 22+ fetch() to reject with HPE_UNEXPECTED_CONTENT_LENGTH.