Skip to content

fix(cubesql): Push Distinct down CubeScan with time dimensions#10518

Merged
ovr merged 1 commit intomasterfrom
cubesql/select-distinct-time-dimension-fix
Mar 18, 2026
Merged

fix(cubesql): Push Distinct down CubeScan with time dimensions#10518
ovr merged 1 commit intomasterfrom
cubesql/select-distinct-time-dimension-fix

Conversation

@MazterQyou
Copy link
Copy Markdown
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR fixes an issue with select-distinct-dimensions rewrite which avoided pushing Distinct down CubeScan when it contained time dimensions. Related test is included.

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou requested a review from a team as a code owner March 18, 2026 08:49
@github-actions github-actions bot added the rust Pull requests that update Rust code label Mar 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.54%. Comparing base (244c04b) to head (01fb2dd).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/mod.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10518   +/-   ##
=======================================
  Coverage   78.54%   78.54%           
=======================================
  Files         473      473           
  Lines       92631    92669   +38     
  Branches     3604     3604           
=======================================
+ Hits        72754    72791   +37     
- Misses      19335    19336    +1     
  Partials      542      542           
Flag Coverage Δ
cube-backend 57.72% <ø> (ø)
cubesql 83.40% <97.36%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr merged commit 028eadc into master Mar 18, 2026
128 of 130 checks passed
@ovr ovr deleted the cubesql/select-distinct-time-dimension-fix branch March 18, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants