Skip to content

feat(schema-compiler): Support currency for numeric measures and dimensions#10561

Merged
ovr merged 10 commits intomasterfrom
feat/schema-currency-support
Mar 26, 2026
Merged

feat(schema-compiler): Support currency for numeric measures and dimensions#10561
ovr merged 10 commits intomasterfrom
feat/schema-currency-support

Conversation

@ovr
Copy link
Copy Markdown
Member

@ovr ovr commented Mar 26, 2026

…dimensions

Allow specifying ISO 4217 currency code (3-letter, e.g. USD,EUR) on measures and number-type dimensions.

…dimensions

Allow specifying ISO 4217 currency code (3-letter, e.g. USD,EUR) on measures
and number-type dimensions.
@github-actions github-actions bot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.56%. Comparing base (f8d79a2) to head (266cb60).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ql/cubeclient/src/models/v1_cube_meta_dimension.rs 0.00% 1 Missing ⚠️
...esql/cubeclient/src/models/v1_cube_meta_measure.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10561   +/-   ##
=======================================
  Coverage   78.55%   78.56%           
=======================================
  Files         473      473           
  Lines       92686    92723   +37     
  Branches     3605     3606    +1     
=======================================
+ Hits        72814    72844   +30     
- Misses      19328    19335    +7     
  Partials      544      544           
Flag Coverage Δ
cube-backend 57.76% <100.00%> (+0.01%) ⬆️
cubesql 83.41% <93.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr force-pushed the feat/schema-currency-support branch from 62538ba to 791480b Compare March 26, 2026 14:43
@github-actions github-actions bot added the client:core Issues relating to the JavaScript client SDK label Mar 26, 2026
@ovr ovr marked this pull request as ready for review March 26, 2026 16:48
@ovr ovr requested review from a team as code owners March 26, 2026 16:48
@ovr ovr changed the title feat(schema-compiler): add currency property to measures and numeric … feat(schema-compiler): Support currency for numeric measures and dimensions Mar 26, 2026
@ovr ovr merged commit 5fc721f into master Mar 26, 2026
86 of 88 checks passed
@ovr ovr deleted the feat/schema-currency-support branch March 26, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client:core Issues relating to the JavaScript client SDK javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants