Skip to content

feat(schema-compiler): Support predefined named numeric formats#10563

Merged
ovr merged 5 commits intomasterfrom
feat/numeric-named-formats
Mar 26, 2026
Merged

feat(schema-compiler): Support predefined named numeric formats#10563
ovr merged 5 commits intomasterfrom
feat/numeric-named-formats

Conversation

@ovr
Copy link
Copy Markdown
Member

@ovr ovr commented Mar 26, 2026

Add named format aliases (abbr, accounting, number_X, percent_X, currency_X, decimal_X) that are validated during schema compilation and resolved to d3-format specifiers as custom-numeric format objects.

Existing bare formats (number, percent, currency, id) are preserved as separate types to avoid a breaking API change.

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Mar 26, 2026
@ovr ovr force-pushed the feat/numeric-named-formats branch 2 times, most recently from 10d6aa5 to 310bdf1 Compare March 26, 2026 18:20
Add named format aliases (abbr, accounting, number_X, percent_X,
currency_X, decimal_X) that are validated during schema compilation
and resolved to d3-format specifiers as custom-numeric format objects.

Existing bare formats (number, percent, currency, id) are preserved
as separate types to avoid a breaking API change.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.79%. Comparing base (5fc721f) to head (6f62b8c).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5fc721f) and HEAD (6f62b8c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5fc721f) HEAD (6f62b8c)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10563       +/-   ##
===========================================
- Coverage   78.56%   57.79%   -20.77%     
===========================================
  Files         473      224      -249     
  Lines       92723    17547    -75176     
  Branches     3606     3609        +3     
===========================================
- Hits        72849    10142    -62707     
+ Misses      19330     6861    -12469     
  Partials      544      544               
Flag Coverage Δ
cube-backend 57.79% <100.00%> (+0.03%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr marked this pull request as ready for review March 26, 2026 19:01
@ovr ovr requested a review from a team as a code owner March 26, 2026 19:01
@ovr ovr merged commit f060f5c into master Mar 26, 2026
73 of 75 checks passed
@ovr ovr deleted the feat/numeric-named-formats branch March 26, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants