fix(playground): multiply percent-formatted values by 100 before display#10624
Merged
ovr merged 1 commit intocube-js:masterfrom Apr 9, 2026
Merged
Conversation
The Playground was displaying format: percent values with a raw % suffix (e.g. 0.273%) instead of multiplying by 100 first (27.3%). This contradicts the documented behavior where presentation tools should apply the multiplication implicitly. Fixes cube-js#10623 Made-with: Cursor
github-actions
bot
added
client:playground
Member
|
Thank you @hank-sq for your contribution 🍰 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Playground displays
format: percentvalues by appending a%suffix to the raw API value without multiplying by 100. This means a value of0.273(representing 27.3%) is shown as0.273%instead of27.3%.Per the official documentation:
This PR fixes all three rendering paths in the Playground:
QueryBuilderResults.tsx— Query Builder V2 results tableTableQueryRenderer.tsx— Drilldown modal tableChartRenderer.tsx— Table chart type (was missing percent handling entirely)Fixes #10623
Test plan
format: percentmeasure (e.g.1.0 * {purchases} / {count})0.5should now display as50%50.00%50.00%Made with Cursor