Conversation
Add a new guide-level Views page to the Data Modeling section, covering why views matter, how they work, design best practices, and folder organization. Also hide the calendar cubes section in dimensions reference, fix the `id` named format to omit grouping commas, and remove the demo deployment callout from the getting started page. Made-with: Cursor
- Create dedicated pages: Cubes, Joins, Measures, Dimensions - Move multi-fact queries under Views as "Multi-fact views" - Move extending cubes under Cubes as "Extending cubes" - Move polymorphic cubes to recipes - Move Syntax to standalone page after AI context - Rewrite Joins page with views-first approach - Rewrite multi-fact page to lead with the problem - Remove old Concepts index page, calculated-members, multi-stage-calculations - Hide data-blending page - Update all cross-references across 30+ files Made-with: Cursor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @keydunov's task in 3m 49s —— View job Review of PR #10698 — Docs data modeling improvements
Overall AssessmentThis is a well-executed restructuring of the data modeling documentation. The old monolithic "Concepts" page (~860 lines) and its sub-pages are replaced by focused, standalone pages for Cubes, Views, Dimensions, Measures, Joins, and Multi-fact Views. The new pages are clearly written, provide both YAML and JavaScript examples, and follow a consistent structure. The navigation is now more intuitive — users can go directly to the topic they need. Excellent work overall. A few issues to address below. Broken Anchor Links1. The heading in
2. The "Join hints" section from the deleted
This content needs to either be added to the new Missing Page in Navigation
The page
The page is now an orphan — it exists but is not reachable from the sidebar. Should it be added to the new nav structure, or should references be redirected? Content Not Migrated from Deleted PagesSeveral sections from the deleted pages were not carried over to the new standalone pages. This may be intentional, but worth confirming:
Minor Issues1. Duplicate link definition in Lines 990 and 999 both define The second definition overrides the first. This is a pre-existing issue but the PR modified line 999, so worth cleaning up. 2. Missing newline at end of several files Multiple modified files are missing a trailing newline (the
3. In Positives
|
Check List