Skip to content

docs: recipes cleanup#10706

Merged
keydunov merged 3 commits intomasterfrom
recipes-cleanup
Apr 16, 2026
Merged

docs: recipes cleanup#10706
keydunov merged 3 commits intomasterfrom
recipes-cleanup

Conversation

@keydunov
Copy link
Copy Markdown
Member

No description provided.

…e measures

Adds a new recipe explaining two approaches to share-of-total calculations:
- calculated fields (% of total) for ad-hoc workbook exploration
- multi-stage measures with Tesseract (group_by: []) for reusable semantic model metrics

Also adds a cursor rule pinning the ecommerce demo as the canonical example data model.

Made-with: Cursor
- Removed mentions of the "Enterprise Premier" plan across multiple documents, replacing them with "Enterprise" where applicable.
- Cleaned up the recipes section by removing references to funnels and XIRR, which are now hidden.
- Adjusted the number of recipes listed in the index to reflect recent changes.

This update ensures consistency in product tier naming and improves the clarity of the documentation.
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 16, 2026

Claude finished @keydunov's task in 2m 38s —— View job


PR Review: docs: recipes cleanup

  • Gather context and review PR diff
  • Review recipe content changes (active-users, percentiles, snapshots, etc.)
  • Review new share-of-total recipe
  • Review entity-attribute-value recipe rewrite
  • Review pricing/tier/admin page updates
  • Review docs.json navigation changes
  • Compile and post review feedback

Overall this is a solid cleanup — removing verbose JSON query/response blocks in favor of concise markdown tables, adding YAML examples alongside JavaScript, removing the deprecated "Enterprise Premier" tier, and adding a well-structured new share-of-total recipe. A few items worth addressing:

Issues

1. designing-metrics is hidden but still in docs.json nav
docs-mintlify/recipes/data-modeling/designing-metrics.mdx has hidden: true added (line 4), and funnels.mdx / xirr.mdx are also hidden. funnels and xirr are correctly removed from the docs.json navigation, but designing-metrics is still listed in docs.json at line 534:

"recipes/data-modeling/designing-metrics",

If the intent is to hide this page from users, it should also be removed from the nav. Fix this →

2. Missing trailing newlines
Two files end without a final newline (visible as \ No newline at end of file in the diff):

  • docs-mintlify/admin/account-billing/support.mdx — ends at line 98 with no trailing newline
  • docs-mintlify/recipes/data-modeling/passing-dynamic-parameters-in-a-query.mdx — ends at line 216 with no trailing newline

Fix this →

3. Unused link reference in share-of-total recipe
docs-mintlify/recipes/data-modeling/share-of-total.mdx line 348 defines [ref-dynamic-params] but it is never referenced anywhere in the file. This is dead markup.

4. Misleading measure name: category_revenue_grand_total
In the "Share of a fixed subtotal" section of share-of-total.mdx (line 255), the helper measure is named category_revenue_grand_total, but it computes a per-category subtotal (via group_by: [category]), not a grand total. Consider renaming to something like category_revenue_subtotal or category_revenue_total to avoid confusion with the actual grand total pattern shown in the section above.

5. Consecutive blank lines left by content removal in audit-log.mdx
After removing images and content blocks, the file has double blank lines at several points (e.g., after line 17, after line 34, after line 41, after line 63). These are cosmetic but slightly messy artifacts.

Suggestions (non-blocking)

6. Recipe count may drift
recipes/index.mdx line 7 says "Explore 38 recipes" — a hardcoded count. With 3 pages hidden (designing-metrics, funnels, xirr) and 1 added (share-of-total), this number needs manual maintenance. Removing the explicit count ("Explore recipes across…") would prevent it from going stale.

7. Result section in audit-log.mdx references removed screenshot
Line 47 says "You can see that a password was sanitized on the screenshot above" — but the screenshot at that location was removed in this PR. The text reference is now dangling.

8. category_revenue_grand_total should also be hidden in the subtotal view example
The "Hiding the helper measure from views" section only shows how to exclude total_revenue_grand_total. It might be worth adding a note that category_revenue_grand_total should similarly be excluded, or showing both in the view excludes example.

What looks good

  • The Enterprise Premier → Enterprise tier consolidation is thorough and consistent across all 15+ admin/deployment pages.
  • The new share-of-total recipe is well-structured with clear use case, two approaches (calculated fields vs data modeling), and proper YAML+JS code groups.
  • EAV recipe rewrite nicely adds YAML examples and the <Note> callouts for JS-only features are a helpful signal.
  • Replacing verbose JSON query/response blocks with concise markdown tables across all updated recipes significantly improves readability.
  • The docs.json nav reordering (Data Modeling first, Core Data API last) is a sensible prioritization.

@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented Apr 16, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟡 Building Apr 16, 2026, 11:32 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@keydunov keydunov merged commit c37370d into master Apr 16, 2026
10 checks passed
@keydunov keydunov deleted the recipes-cleanup branch April 16, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant