feat(cubestore-driver): Upgrade flatbuffers to 25.9.23#10717
Conversation
Bumps flatbuffers from 23.3.3 to 25.9.23 and regenerates the TS bindings from http_message.fbs. Also switches the generator flag from the deprecated --ts-flat-files to --gen-all. Notable runtime improvement: createString now uses Uint8Array.set instead of a per-byte loop, which is ~2-3x faster for large payloads such as the csv_rows field on inline tables.
|
Claude finished @ovr's task in 1m 17s —— View job PR Review: Upgrade flatbuffers to 25.9.23
Verdict: Looks good ✅ This is a clean, low-risk dependency upgrade. The changes are minimal and well-scoped. What changed
API compatibilityI verified that every symbol consumed by the sole consumer (
The FlatBuffers schema ( PerformanceThe PR description's claim about No concerns
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #10717 +/- ##
===========================================
- Coverage 83.40% 58.02% -25.39%
===========================================
Files 251 215 -36
Lines 75297 16688 -58609
Branches 0 3358 +3358
===========================================
- Hits 62802 9683 -53119
+ Misses 12495 6513 -5982
- Partials 0 492 +492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bumps flatbuffers from 23.3.3 to 25.9.23 and regenerates the TS bindings from http_message.fbs. Also switches the generator flag from the deprecated --ts-flat-files to --gen-all.
Notable runtime improvement: createString now uses Uint8Array.set instead of a per-byte loop, which is ~2-3x faster for large payloads such as the csv_rows field on inline tables.