docs: dashboard widgets

[keydunov]

Check List

• Tests have been run in packages where changes have been made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

[claude]

Claude finished @keydunov's task in 1m 45s —— View job

---

Review of PR #10744: docs: dashboard widgets

• Gather context and read all changed files
• Review documentation content and structure
• Review navigation configuration (docs.json)
• Check for unrelated/accidental changes
• Post final review

---

Overall this is a well-structured addition of dashboard widget documentation. The content is clear, well-organized, and the navigation hierarchy makes sense. Here are my findings:

Issues to address

1. docs-mintlify/package.json and yarn.lock — likely unintended addition (7,200+ lines)

The PR adds a new docs-mintlify/package.json and a 7,197-line yarn.lock. These files didn't exist on master before. The root package.json workspaces config only covers packages/* and rust/*, so docs-mintlify/ is not part of the monorepo workspace.

This seems like a local development artifact that shouldn't be committed — the docs-mintlify/ directory likely uses Mintlify's hosted build pipeline rather than a local yarn install. If these files are intentional, they should be documented in the PR description. If not, they should be removed.

Fix this →

2. .cursor/rules/namings-rule.mdc — trailing whitespace on line 31

Line 31 has a trailing space after Controls:

          - Controls ← trailing space here

Minor, but worth cleaning up.

Fix this →

Suggestions (non-blocking)

3. controls.mdx — [ref-granularities] link text is slightly misleading

In controls.mdx:98, the reference link [ref-granularities] points to /docs/data-modeling/dimensions, which is the general dimensions page. Since the text references "granularity" and "custom granularities defined in the data model," consider linking to a more specific anchor or section if one exists on that page, or noting it's the dimensions reference.

4. widgets/index.mdx — unused reference link

In widgets/index.mdx:19, the reference [ref-workbooks] is defined but never used in the page body. The dashboard builder mention on line 6 uses inline bracket syntax ([dashboard builder][ref-workbooks]) which does use it — so this is actually fine on closer look. Disregard.

5. Markdown link style is consistent — Good use of reference-style links ([text][ref-name]) throughout all new pages. All cross-references resolve to existing files.

What looks good

• Navigation structure in docs.json is clean — the Dashboards > Widgets hierarchy with root pages follows the same pattern used elsewhere (e.g., Charts, Workbooks).
• Content quality is strong — the controls page is particularly thorough with the operators table, faceted filters explanation, visibility settings, and controls mapping.
• Product taxonomy update in .cursor/rules/namings-rule.mdc correctly mirrors the widget types documented in the new pages.
• Dashboards index was properly refactored from a flat file (dashboards.mdx) to a directory with index.mdx to accommodate the new sub-pages.

Summary

The documentation content itself is excellent. The main concern is the package.json + yarn.lock addition (7,200+ lines / 96% of the diff) — please confirm whether these are intentional or should be removed.