Skip to content

docs: update semantic snowflake semantic views doc following CUB-2368#10810

Open
MikeNitsenko wants to merge 1 commit intomasterfrom
docs-CUB-2416/update-semantic-snowflake-semantic-views-doc-following-cub-2368
Open

docs: update semantic snowflake semantic views doc following CUB-2368#10810
MikeNitsenko wants to merge 1 commit intomasterfrom
docs-CUB-2416/update-semantic-snowflake-semantic-views-doc-following-cub-2368

Conversation

@MikeNitsenko
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pr:community Contribution from Cube.js community members. label May 4, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 4, 2026

Claude finished @MikeNitsenko's task in 53s —— View job


Review of PR #10810

  • Gather context and read changed files
  • Review documentation changes
  • Post review feedback

Summary

This PR updates the Snowflake Semantic Views documentation to reflect new behavior from CUB-2368: cubes defined with a sql property (instead of sql_table) are now partially supported during a push to Snowflake. The changes are well-structured and cover three areas:

  1. New section ("Cubes defined with sql") explaining how plain SQL strings, simple table references, and templated SQL are handled.
  2. Updated prerequisites noting the additional CREATE VIEW privilege needed for helper views.
  3. Revised limitations replacing the blanket "no sql cubes" restriction with the more nuanced "only templated sql is unsupported."

Feedback

Looks good overall. The documentation is clear, well-organized, and the new section slots in naturally before Prerequisites. A few minor observations:

1. Helper view schema configurability — missing details

docs-mintlify/docs/integrations/snowflake-semantic-views.mdx:57-58

The text mentions the helper view schema "defaults to PUBLIC" and is "configurable," but doesn't explain how to configure it (e.g., an environment variable or a UI setting). This appears again at line 78. A reader who needs a non-PUBLIC schema won't know where to set it.

Consider adding a brief note or link, e.g., "configurable via CUBEJS_DB_SNOWFLAKE_... (see configuration reference)." If the configuration mechanism isn't documented yet, it may be worth a follow-up.

2. Anchor link correctness ✅

The internal link [Cubes defined with \sql`](#cubes-defined-with-sql)` at line 103 correctly matches the heading added at line 51. Verified this is consistent.

3. Commit message

The commit message is just upd — while this doesn't block the PR, a more descriptive message (e.g., docs: document sql property support for Snowflake semantic views push) would be more helpful for future git log archaeology. This follows the repo's conventional commit guidelines in CLAUDE.md.

4. Minor wording nit

docs-mintlify/docs/integrations/snowflake-semantic-views.mdx:61

treated the same as \sql_table``

This could be slightly clearer as "treated the same as sql_table" → "resolved the same way as sql_table" to avoid ambiguity about whether it's literally converted or just handled equivalently. Very minor — take or leave.


Verdict: The content changes are accurate, well-structured, and improve the docs meaningfully. The only actionable suggestion is clarifying how the helper view schema is configured (item 1 above). Approving with that minor callout. 👍

@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 4, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview May 4, 2026, 4:33 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant