Skip to content

docs: document user attribute defaults for dashboard filters#10814

Merged
keydunov merged 1 commit intomasterfrom
docs/user-attribute-defaults-for-dashboard-filters
May 5, 2026
Merged

docs: document user attribute defaults for dashboard filters#10814
keydunov merged 1 commit intomasterfrom
docs/user-attribute-defaults-for-dashboard-filters

Conversation

@keydunov
Copy link
Copy Markdown
Member

@keydunov keydunov commented May 5, 2026

Expand the Filter widget's "Default values" section to cover the new user attribute default toggle that resolves the filter's initial value from the viewer's user attribute at load time.

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Expand the Filter widget's "Default values" section to cover the new
user attribute default toggle that resolves the filter's initial value
from the viewer's user attribute at load time.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 5, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview May 5, 2026, 4:39 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 5, 2026

Claude finished @keydunov's task in 1m 11s —— View job


Review: docs: document user attribute defaults for dashboard filters

  • Gather context and read changed files
  • Review documentation changes for accuracy and clarity
  • Post review feedback

Overall: This is a well-written docs addition. The new section is clear, well-structured, and slots naturally into the existing page. A few minor suggestions below.

What looks good

  • Clean two-tier structure (static vs. user attribute defaults) with a concise intro before diving into the user attribute section.
  • The <Steps> component matches the pattern used elsewhere in the Mintlify docs (e.g., pre-aggregations/overview.mdx, OIDC setup pages).
  • The attribute-type matching table is a helpful quick-reference — particularly the note about arrays having empty values dropped.
  • The fallback behavior paragraph (line 67) is excellent: it covers nulls, static-default fallback, and URL parameter precedence in one concise block.
  • The [ref-user-attributes] link target (/admin/users-and-permissions/user-attributes) is correct and consistent with how other docs reference it.

Suggestions

  1. Consider a <Note> or <Info> callout for the precedence/visibility paragraph (line 69)

    The paragraph starting with "The user attribute default only seeds the filter's initial value…" packs important behavioral nuances (visibility lock, URL parameter precedence). A Mintlify <Info> callout would make it stand out so readers don't skim past it:

    <Info>
    The user attribute default only seeds the filter's *initial* value. Viewers can still change the filter unless its [visibility](#visibility) is set to **Disabled**, in which case the resolved attribute value is locked in for that viewer. Values passed via URL parameters also take precedence over user attribute defaults, so deep links continue to work.
    </Info>
  2. Minor: "Boolean" attribute type not mentioned (lines 62–65)

    The attribute-type table covers String, Number, and their array variants. If user attributes can also be Booleans, it may be worth a brief note — even just to say they aren't supported as filter defaults. If Booleans aren't a valid attribute type, ignore this.

  3. Singular vs. plural in link text (lines 36, 42, 56)

    The links read [user attribute][ref-user-attributes] (singular text, plural ref label). This is fine and consistent within the file, just flagging it as intentional — the plural ref label matches other docs' convention.

No issues found

  • Security: No concerns — this is purely documentation with no executable code.
  • Broken links: The [ref-user-attributes] target exists at docs-mintlify/admin/users-and-permissions/user-attributes.mdx. Internal anchors (#visibility, #disabled) reference sections that exist on the same page.
  • Component usage: <Steps> and <Step> are used in other Mintlify docs in this repo, so the pattern is established.
  • Formatting: Tables, bold text, inline code, and MDX components are all syntactically correct.

LGTM with minor suggestions — none are blocking. Nice addition! 👍

@keydunov keydunov merged commit 0a7948e into master May 5, 2026
11 checks passed
@keydunov keydunov deleted the docs/user-attribute-defaults-for-dashboard-filters branch May 5, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant