Skip to content

fix(playground): stabilize onQueryChange callback to prevent stale closures #10815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
keydunov wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Draft

fix(playground): stabilize onQueryChange callback to prevent stale closures #10815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/cubejs-playground/src/QueryBuilderV2/hooks/query-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ export function useQueryBuilder(props: UseQueryBuilderProps) {
onQueryChange,
} = props;

const onQueryChangeStable = useEvent((...args: Parameters<NonNullable<typeof onQueryChange>>) => {
onQueryChange?.(...args);
});

function queryValidation(query: Query) {
let validatedQuery = validateQuery(query);

Expand Down Expand Up @@ -1024,7 +1028,7 @@ export function useQueryBuilder(props: UseQueryBuilderProps) {
}, [queryHash, chartType, meta]);

useEffect(() => {
onQueryChange?.({ query, chartType, pivotConfig });
onQueryChangeStable({ query, chartType, pivotConfig });
}, [queryHash, chartType, pivotConfig]);

// Update invalidation markers
Expand Down
Loading