Skip to content

style(docs): make legacy-docs banner taller and more prominent#10910

Merged
keydunov merged 1 commit into
masterfrom
cursor/legacy-docs-banner-taller
May 19, 2026
Merged

style(docs): make legacy-docs banner taller and more prominent#10910
keydunov merged 1 commit into
masterfrom
cursor/legacy-docs-banner-taller

Conversation

@keydunov
Copy link
Copy Markdown
Member

Bumps the Nextra banner padding and font-size so the "Visit the new docs" notice on the old documentation site is harder to miss.

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Bumps the Nextra banner padding and font-size so the "Visit the new docs"
notice on the old documentation site is harder to miss.

Co-authored-by: Cursor <cursoragent@cursor.com>
@keydunov keydunov merged commit c1f0ac7 into master May 19, 2026
11 checks passed
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude finished @keydunov's task in 1m 27s —— View job


Code Review: PR #10910

  • Gather context and review changes
  • Analyze code quality, security, and best practices
  • Provide review feedback

Scope: +7 lines in docs/app/globals.css — adds CSS overrides for the Nextra banner to make the legacy-docs redirect notice more visible.

/* Legacy-docs Banner - taller bar so the "visit new docs" link is more prominent */
.nextra-banner > div {
  padding-top: 32px !important;
  padding-bottom: 32px !important;
  font-size: 1.125rem !important;
}

Feedback

Looks good. This is a small, focused styling change and accomplishes its stated goal. A few minor observations:

  1. !important usage — Consistent with the rest of globals.css, which uses !important throughout to override Nextra's built-in styles. No concern here given the established pattern.

  2. Mobile responsiveness — The 32px vertical padding might feel large on small viewports where vertical space is at a premium. Consider whether a media query to reduce padding on mobile would be worthwhile (e.g., padding: 16px below 768px). Not a blocker — the banner is intentionally meant to be prominent, so the extra height may be desirable even on mobile.

  3. Selector specificity.nextra-banner > div is a reasonable selector for targeting Nextra's banner container. It depends on Nextra's internal DOM structure, but that's an accepted trade-off already present across this file.

  4. Comment quality — Good descriptive comment explaining the "why" behind the override.

No security, performance, or testing concerns for a CSS-only change of this size.

Verdict: Approved. Clean, minimal change that fits the existing codebase conventions.

@keydunov keydunov deleted the cursor/legacy-docs-banner-taller branch May 19, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant