Skip to content

Conversation

@frolovdev
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@frolovdev frolovdev requested a review from a team as a code owner August 23, 2022 15:19
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #5144 (47aa4c7) into master (e64db05) will decrease coverage by 14.42%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5144       +/-   ##
===========================================
- Coverage   74.47%   60.05%   -14.43%     
===========================================
  Files         268      139      -129     
  Lines       31174    11567    -19607     
  Branches     2912     2912               
===========================================
- Hits        23218     6946    -16272     
+ Misses       7454     4119     -3335     
  Partials      502      502               
Flag Coverage Δ
cube-backend 60.05% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/compile/engine/information_schema/mysql/ext.rs
rust/cubesql/cubesql/src/compile/mod.rs
...ust/cubesql/cubesql/src/compile/engine/provider.rs
...t/cubesql/cubesql/src/compile/rewrite/converter.rs
rust/cubesql/cubesql/src/compile/parser.rs
...engine/information_schema/postgres/pg_namespace.rs
...pile/engine/information_schema/mysql/statistics.rs
...e/engine/information_schema/redshift/svv_tables.rs
rust/cubesql/cubeclient/src/apis/configuration.rs
rust/cubesql/cubesql/src/sql/session.rs
... and 119 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@frolovdev frolovdev merged commit a3a8b89 into master Aug 23, 2022
@frolovdev frolovdev deleted the bugfix/databricks-agent branch August 23, 2022 16:48
nayakravi pushed a commit to trueanthem/cube.js that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants