Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Oct 3, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@paveltiunov paveltiunov requested a review from a team as a code owner October 3, 2022 22:23
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 61.14% // Head: 61.14% // No change to project coverage 👍

Coverage data is based on head (4920b03) compared to base (041f591).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5417   +/-   ##
=======================================
  Coverage   61.14%   61.14%           
=======================================
  Files         140      140           
  Lines       11985    11985           
  Branches     2933     2935    +2     
=======================================
  Hits         7328     7328           
  Misses       4367     4367           
  Partials      290      290           
Flag Coverage Δ
cube-backend 61.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bejs-schema-compiler/src/compiler/CubeEvaluator.js 74.86% <ø> (ø)
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 70.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov merged commit bfe76bf into master Oct 3, 2022
@paveltiunov paveltiunov deleted the segment-filter-params-fix branch October 3, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants