Skip to content

Conversation

@mcheshkov
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Run cargo check for all targets in cubesql
Run rustfmt for all cubesql workspace
Add --locked to clippy runs in cubejs-backend-native

@codecov
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.45%. Comparing base (361f0f0) to head (69470c7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8595      +/-   ##
==========================================
- Coverage   82.45%   82.45%   -0.01%     
==========================================
  Files         209      209              
  Lines       76191    76191              
==========================================
- Hits        62827    62822       -5     
- Misses      13364    13369       +5     
Flag Coverage Δ
cubesql 82.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review August 19, 2024 14:35
@mcheshkov mcheshkov requested a review from a team as a code owner August 19, 2024 14:35
@mcheshkov mcheshkov merged commit e137630 into master Aug 19, 2024
@mcheshkov mcheshkov deleted the cubesql-more-ci-checks branch August 19, 2024 14:51
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants