Skip to content

ci: More CI checks in cubesql and cubejs-backend-native #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2024
Merged

ci: More CI checks in cubesql and cubejs-backend-native #8595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9562231
Fixes in large_model.rs after refactorings
mcheshkov Aug 17, 2024
1823ba3
Setup cargo check in CI for all targets in cubesql
mcheshkov Aug 17, 2024
1d1f76a
Run rustfmt in all cubesql workspace in CI
mcheshkov Aug 19, 2024
69470c7
Make clippy locked and check all targets in CI for cubejs-backend-native
mcheshkov Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/rust-cubesql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,16 @@ jobs:
key: cubesql-${{ runner.OS }}-x86_64-unknown-linux-gnu
shared-key: cubesql-${{ runner.OS }}-x86_64-unknown-linux-gnu
- name: Lint CubeSQL
run: cd rust/cubesql/cubesql && cargo fmt --all -- --check
run: cd rust/cubesql && cargo fmt --all -- --check
- name: Lint Native
run: cd packages/cubejs-backend-native && cargo fmt --all -- --check
# TODO replace with clippy once cubesql is ready
- name: Check CubeSQL
run: cd rust/cubesql && cargo check --locked --workspace --all-targets --keep-going
- name: Clippy Native
run: cd packages/cubejs-backend-native && cargo clippy -- -D warnings
run: cd packages/cubejs-backend-native && cargo clippy --locked --workspace --all-targets --keep-going -- -D warnings
- name: Clippy Native (with Python)
run: cd packages/cubejs-backend-native && cargo clippy --features python -- -D warnings
run: cd packages/cubejs-backend-native && cargo clippy --locked --workspace --all-targets --keep-going --features python -- -D warnings
# CubeSQL is not ready for Clippy
#- name: Clippy CubeSQL
# run: cd rust/cubesql && cargo clippy -- -D warnings
Expand Down
4 changes: 2 additions & 2 deletions rust/cubesql/cubesql/benches/large_model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ use uuid::Uuid;
macro_rules! bench_large_model {
($DIMS:expr, $NAME:expr, $QUERY_FN:expr, $CRITERION:expr) => {{
let context = Arc::new(
futures::executor::block_on(create_test_cube_context(
create_test_postgresql_cube_context($DIMS),
futures::executor::block_on(create_test_postgresql_cube_context(
get_large_model_test_tenant_ctx($DIMS),
))
.unwrap(),
);
Expand Down