Skip to content

Conversation

@morgan-at-cube
Copy link
Contributor

The masking function example in this document generates SQL like this:
SELECT "'--- masked ---'" "users__first_name" FROM ECOM.USERS AS "users"
This is incorrect because quotes indicate a column name. If we remove the escaped quotes, then the query works.

Definitely feel free to tell me I'm wrong, this is just what I experienced in testing!

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@vercel
Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 2, 2024
@igorlukanin igorlukanin self-requested a review November 22, 2024 12:46
@igorlukanin igorlukanin added the docs Issues that require a documentation improvement label Nov 22, 2024
@paveltiunov paveltiunov merged commit f8c3d3a into cube-js:master Dec 12, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues that require a documentation improvement pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants