Skip to content

Conversation

@HaidarZ
Copy link
Contributor

@HaidarZ HaidarZ commented Jan 28, 2025

This pull request updates the @cubejs-client/ngx library to fix its outdated Angular Package Format (APF) configuration and ensure compatibility with Angular 12+. Key changes include aligning the build and TypeScript settings with Angular 13 standards, updating the README to reflect the new minimum Angular version, and switching the fast-deep-equal import paths to ES6 modules. These fixes resolve build errors and maintain backward compatibility for projects on older Angular versions.

Issue Reference this PR resolves
#9140

@HaidarZ HaidarZ requested a review from a team as a code owner January 28, 2025 21:00
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jan 28, 2025
@HaidarZ HaidarZ changed the title Fix @cubejs-client/ngx not working post version 1.0.0 fix(@cubejs-client/ngx): Update APF configuration and build settings for Angular 12+ compatibility Jan 28, 2025
@HaidarZ
Copy link
Contributor Author

HaidarZ commented Jan 28, 2025

@HaidarZ HaidarZ force-pushed the fix/cubejs_ngx_9140 branch from 2af9a45 to cbf332b Compare January 30, 2025 20:46
@vasilev-alex vasilev-alex merged commit 57bcbc4 into cube-js:master Jan 31, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants