Skip to content

fix(schema-compiler): hierarchies to respect prefix value #9239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix(schema-compiler): hierarchies to respect prefix value #9239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/cubejs-schema-compiler/src/compiler/CubeEvaluator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,11 @@ export class CubeEvaluator extends CubeSymbols {
if (cube.isView && (cube.includedMembers || []).length) {
const includedMemberPaths: string[] = R.uniq(cube.includedMembers.map(it => it.memberPath));
const includedCubeNames: string[] = R.uniq(includedMemberPaths.map(it => it.split('.')[0]));
// Path to name (which can be prefixed or aliased) map for hierarchy
const hierarchyPathToName = cube.includedMembers.filter(it => it.type === 'hierarchies').reduce((acc, it) => ({
...acc,
[it.memberPath]: it.name
}), {});
const includedHierarchyNames = cube.includedMembers.filter(it => it.type === 'hierarchies').map(it => it.memberPath.split('.')[1]);

for (const cubeName of includedCubeNames) {
Expand All @@ -260,8 +265,13 @@ export class CubeEvaluator extends CubeSymbols {
return null;
}).filter(Boolean);

const name = hierarchyPathToName[[cubeName, it.name].join('.')];
if (!name) {
throw new UserError(`Hierarchy '${it.name}' not found in cube '${cubeName}'`);
}
return {
...it,
name,
levels
};
})
Expand Down
4 changes: 4 additions & 0 deletions packages/cubejs-schema-compiler/test/unit/hierarchies.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ describe('Cube hierarchies', () => {
(it) => it.config.name === 'all_hierarchy_view'
);
expect(allHierarchyView.config.hierarchies.length).toBe(3);

const prefixedHierarchy = allHierarchyView.config.hierarchies.find((it) => it.name === 'all_hierarchy_view.users_users_hierarchy');
expect(prefixedHierarchy).toBeTruthy();
expect(prefixedHierarchy?.levels).toEqual(['all_hierarchy_view.users_age', 'all_hierarchy_view.users_city']);
});

it(('hierarchy with measure'), async () => {
Expand Down
Loading