feat(pinot-driver): Add enableNullHandling to query options using env var #9310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
Co-authored-by: ron-damon <48366185+ron-damon@users.noreply.github.com>
Co-authored-by: ron-damon <48366185+ron-damon@users.noreply.github.com>
Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
…eat/driver/pinot/add-enable-null-handling-config
github-actions
bot
added
the
pr:community
KSDaemon
approved these changes
Mar 7, 2025
Member
KSDaemon
left a comment
KSDaemon
left a comment
There was a problem hiding this comment.
👍🏻 Great! Thnx for the update!
marianore-muttdata
added a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
… var (cube-js#9310) * feat(pinot-driver): Add enableNullHandling=true to query options * Add enableNullHandling=true to query options using env var CUBEJS_DB_NULL_HANDLING * Add 'The Startree/Pinot null value support' to docs * fix reference env var * Update docs/pages/product/configuration/data-sources/pinot.mdx Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com> * Update docs/pages/reference/configuration/environment-variables.mdx Co-authored-by: ron-damon <48366185+ron-damon@users.noreply.github.com> * Update docs/pages/reference/configuration/environment-variables.mdx Co-authored-by: ron-damon <48366185+ron-damon@users.noreply.github.com> * Update packages/cubejs-backend-shared/src/env.ts Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com> * fix env var name * Add docs for auth token config --------- Co-authored-by: Igor Lukanin <igor@cube.dev> Co-authored-by: sergisulca <sergio.sulca@muttdata.ai> Co-authored-by: Sergio Sulca <104989816+sergisulca@users.noreply.github.com> Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com> Co-authored-by: ron-damon <48366185+ron-damon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Note: Last PR wasn't merged to
masterand thus the changes were lost and the source branch seems to be deleted.Description of Changes Made
CUBEJS_DB_PINOT_AUTH_TOKENconfig.CUBEJS_DB_PINOT_NULL_HANDLINGto enable that property at query level.