Skip to content

Conversation

@mcheshkov
Copy link
Contributor

@mcheshkov mcheshkov commented Mar 17, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

It can drop projection for mismatched alias in UNION ALL, leading to missing columns and out-of-bounds panic during execution in DF

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.72%. Comparing base (c336b10) to head (3e0d732).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/query_engine.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9356      +/-   ##
==========================================
- Coverage   83.74%   83.72%   -0.02%     
==========================================
  Files         229      229              
  Lines       82538    82574      +36     
==========================================
+ Hits        69121    69138      +17     
- Misses      13417    13436      +19     
Flag Coverage Δ
cubesql 83.72% <97.82%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov marked this pull request as ready for review March 17, 2025 18:12
@mcheshkov mcheshkov requested a review from a team as a code owner March 17, 2025 18:12
@mcheshkov mcheshkov force-pushed the union-all-alias-mismatch branch from bd9e66a to 3e0d732 Compare March 17, 2025 18:53
@mcheshkov mcheshkov merged commit a15442c into master Mar 17, 2025
74 checks passed
@mcheshkov mcheshkov deleted the union-all-alias-mismatch branch March 17, 2025 19:29
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
It can drop projection for mismatched alias in UNION ALL
Also catch wrapper nodes in is_olap_query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants