Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR changes the behavior of normalize_col function to alias an expression when it was modified. This fixes an issue with Projection -> Aggregate -> CubeScan plans having inconsistent qualifiers (or lack thereof).

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou requested a review from a team as a code owner April 22, 2025 11:54
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (cd7e9fd) to head (d577d8c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9498       +/-   ##
===========================================
+ Coverage   59.07%   80.55%   +21.47%     
===========================================
  Files         153      382      +229     
  Lines       13017    96586    +83569     
  Branches     2202     2202               
===========================================
+ Hits         7690    77801    +70111     
- Misses       5014    18472    +13458     
  Partials      313      313               
Flag Coverage Δ
cube-backend 59.07% <ø> (ø)
cubesql 83.89% <95.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

let original_expr_name = expr_name(&expr)?;
let mut normalized_expr = df_normalize_col(expr, plan)?;
let normalized_expr_name = expr_name(&normalized_expr)?;
if original_expr_name != normalized_expr_name {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MazterQyou MazterQyou merged commit 32f9b79 into master Apr 22, 2025
70 checks passed
@MazterQyou MazterQyou deleted the cubesql/normalize-col-realias branch April 22, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants