Skip to content

Conversation

@mcheshkov
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This is necessary to support queries where output references only join subqueries.
Before, when query does have subqeury joins, but does not have any measures/dimensions/... join hints would be empty, and join tree would be null, which is almost okay, but to generate query with join subqueries we need to build join query, so join tree is more-or-less required.

This is necessary to support queries where output references only join subqueries
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.70%. Comparing base (1deddcc) to head (460d5ff).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 37.50% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1deddcc) and HEAD (460d5ff). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1deddcc) HEAD (460d5ff)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9554       +/-   ##
===========================================
- Coverage   80.39%   61.70%   -18.70%     
===========================================
  Files         395      174      -221     
  Lines       97932    14439    -83493     
  Branches     2278     2464      +186     
===========================================
- Hits        78731     8909    -69822     
+ Misses      18893     5161    -13732     
- Partials      308      369       +61     
Flag Coverage Δ
cube-backend 61.69% <37.50%> (+4.35%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov marked this pull request as ready for review May 7, 2025 16:31
@mcheshkov mcheshkov requested review from a team as code owners May 7, 2025 16:31
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@ovr ovr merged commit cbf0bfd into master May 15, 2025
61 checks passed
@ovr ovr deleted the pickup-join-hints-from-subq-joins branch May 15, 2025 15:15
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
cube-js#9554)

This is necessary to support queries where output references only join subqueries.
Before, when query does have subqeury joins, but does not have any measures/dimensions/... join hints would be empty, and join tree would be null, which is almost okay, but to generate query with join subqueries we need to build join query, so join tree is more-or-less required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants