Support more dbt contract data types #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `column_to_dimension_types` to a constant, at the top of the file, TYPE_MAPPINGS. - Normalize data types coming from dbt contracts by: - Downcasing - Remove extra type detail, contained in parentheses (ex. "timestamp(3)" => "timestamp") - After looking up the type mapping, compare the target type against the short list of supported dimension types in cube. - Support all data types in Snowflake and make a best effort of mapping them. - I assume the bool => boolean mapping comes from a BigQuery data type, so moved that into its own constant.
- Since we started BIGQUERY_TYPE_MAPPINGS, let's add the rest of the BigQuery types to the map. - Enhance normalizing data types coming from dbt contracts by: - Remove extra type detail, contained in angle brackets (ex. "array<struct<array<int64>>>" => "array")
- Since we've added support for Snowflake and BigQuery, let's wrap this up by adding support for data types from the other major data warehouse, Redshift
igorlukanin
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more dbt contract data types (Snowflake)
Support more dbt contract data types (BigQuery)
Support more dbt contract data types (Redshift)