Skip to content

Conversation

@MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Jun 10, 2022

This PR adds support for parsing expressions (like placeholders or subqueries) in LIMIT. It also boxes a Query in Cte, following the same approach as with other Query instances.

@coveralls
Copy link

coveralls commented Jun 10, 2022

Pull Request Test Coverage Report for Build 2507500117

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.762%

Totals Coverage Status
Change from base Build 2448443641: 0.005%
Covered Lines: 8487
Relevant Lines: 9455

💛 - Coveralls

@MazterQyou MazterQyou changed the title feat: Allow placeholders in LIMIT feat: Allow expressions in LIMIT Jun 16, 2022
@MazterQyou MazterQyou merged commit 9cd6792 into cubesql-v0.16.0 Jun 16, 2022
@MazterQyou MazterQyou deleted the limit-expr branch June 16, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants