Skip to content

Conversation

@MazterQyou
Copy link
Member

This PR fixes parsing of expressions like INTERVAL '1 day' + INTERVAL '1 day'. Previously those were interpreted as INTERVAL ('1 day' + INTERVAL '1 day'). It also adds a related test.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3083661578

  • 33 of 33 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 85.126%

Totals Coverage Status
Change from base Build 3000840574: 0.05%
Covered Lines: 8699
Relevant Lines: 10219

💛 - Coveralls

Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MazterQyou MazterQyou merged commit 4b67b56 into cubesql-v0.16.0 Sep 19, 2022
@MazterQyou MazterQyou deleted the interval-sum branch September 19, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants