Skip to content

Conversation

@MazterQyou
Copy link
Member

This PR contains commits cherry-picked from upstream that add support for POSITION(substr IN str) function.

yuval-illumex and others added 2 commits October 24, 2022 21:07
* Add support in the position function

* Add Test

* Add lint fixes

* Remove if

* Change from to in

* Remove special method for position

* Fix lint

* PR Review
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3314725902

  • 19 of 20 (95.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.202%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 10 11 90.91%
Totals Coverage Status
Change from base Build 3274070738: 0.02%
Covered Lines: 8798
Relevant Lines: 10326

💛 - Coveralls

@MazterQyou MazterQyou merged commit 2b18e22 into cubesql-v0.16.0 Oct 25, 2022
@MazterQyou MazterQyou deleted the position-in branch October 25, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants