Skip to content

Conversation

@MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Dec 1, 2022

This PR adds support for APPROXIMATE keyword for functions. This is used by Redshift with some functions, such as COUNT. A related test is also added.
Additionally, this PR locks Rust toolchain to the one used by cubesql, and locks versions of dependencies to avoid CI deprecation notices in newer versions.

@MazterQyou MazterQyou force-pushed the cubesql-approximate-func branch 3 times, most recently from a1dab32 to 5540043 Compare December 1, 2022 02:26
@MazterQyou MazterQyou force-pushed the cubesql-approximate-func branch from 5540043 to b7407b9 Compare December 1, 2022 02:29
@MazterQyou MazterQyou merged commit 883cc6a into cubesql-v0.16.0 Dec 1, 2022
@MazterQyou MazterQyou deleted the cubesql-approximate-func branch December 1, 2022 02:44
@coveralls
Copy link

coveralls commented Dec 1, 2022

Pull Request Test Coverage Report for Build 3588892612

  • 30 of 35 (85.71%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+4.6%) to 89.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_postgres.rs 20 22 90.91%
src/parser.rs 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
src/parser.rs 4 82.96%
Totals Coverage Status
Change from base Build 3322086153: 4.6%
Covered Lines: 8732
Relevant Lines: 9724

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants