Skip to content

Implement process of adding "Direction" ViewerPreferences#52

Merged
clown merged 1 commit intocube-soft:masterfrom
Qatleph:add_page_direction
May 8, 2025
Merged

Implement process of adding "Direction" ViewerPreferences#52
clown merged 1 commit intocube-soft:masterfrom
Qatleph:add_page_direction

Conversation

@Qatleph
Copy link
Copy Markdown
Contributor

@Qatleph Qatleph commented Apr 13, 2025

Reason of change

When "Two page (right)" or "Two column (right)" is specified in "Metadata > Layout" in "CubePDF Pages", "Direction" is not specified, so when viewed in a PDF viewer such as Adobe Acrobat Reader, it is not displayed right-bound.

Solution

Changed to add "RIGHT_TO_LEFT" when "TwoColumnRight" or "TwoPageRight" is specified in "ViewerOption".


Pre-translation text

変更の理由

「CubePDF Pages」で「文書プロパティ > ページレイアウト」に「見開きページ (右綴じ)」や「連続見開きページ (右綴じ)」を指定した時に"Direction"が指定されないため、Adobe Acrobat ReaderなどのPDFビュワーで閲覧した際に右綴じで表示されません。

解決策

「ViewerOption」として "TwoColumnRight" か "TwoPageRight" が指定された時、"RIGHT_TO_LEFT" を追加するよう変更しました。

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.46%. Comparing base (73b5212) to head (af4fe05).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
Libraries/Itext/Sources/Internal/Writer.cs 70.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   79.45%   79.46%           
=======================================
  Files         274      274           
  Lines       10456    10465    +9     
  Branches      952      954    +2     
=======================================
+ Hits         8308     8316    +8     
+ Misses       1882     1881    -1     
- Partials      266      268    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clown clown merged commit b45a5c3 into cube-soft:master May 8, 2025
3 of 4 checks passed
@clown
Copy link
Copy Markdown
Member

clown commented May 13, 2025

Thank you for your pull request. After re-examining the issue, it appears that we may need to support more various conditions (e.g., the pre-modified layout should also be configurable as “with cover”), so we have disabled the imported modifications temporarily.

We have identified this as an issue and will fix it in the future so that the settings we received in the pull request will also be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants