Implement process of adding "Direction" ViewerPreferences#52
Merged
clown merged 1 commit intocube-soft:masterfrom May 8, 2025
Merged
Implement process of adding "Direction" ViewerPreferences#52clown merged 1 commit intocube-soft:masterfrom
clown merged 1 commit intocube-soft:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 79.45% 79.46%
=======================================
Files 274 274
Lines 10456 10465 +9
Branches 952 954 +2
=======================================
+ Hits 8308 8316 +8
+ Misses 1882 1881 -1
- Partials 266 268 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thank you for your pull request. After re-examining the issue, it appears that we may need to support more various conditions (e.g., the pre-modified layout should also be configurable as “with cover”), so we have disabled the imported modifications temporarily. We have identified this as an issue and will fix it in the future so that the settings we received in the pull request will also be available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason of change
When "Two page (right)" or "Two column (right)" is specified in "Metadata > Layout" in "CubePDF Pages", "Direction" is not specified, so when viewed in a PDF viewer such as Adobe Acrobat Reader, it is not displayed right-bound.
Solution
Changed to add "RIGHT_TO_LEFT" when "TwoColumnRight" or "TwoPageRight" is specified in "ViewerOption".
Pre-translation text
変更の理由
「CubePDF Pages」で「文書プロパティ > ページレイアウト」に「見開きページ (右綴じ)」や「連続見開きページ (右綴じ)」を指定した時に"Direction"が指定されないため、Adobe Acrobat ReaderなどのPDFビュワーで閲覧した際に右綴じで表示されません。
解決策
「ViewerOption」として "TwoColumnRight" か "TwoPageRight" が指定された時、"RIGHT_TO_LEFT" を追加するよう変更しました。