Merged
Conversation
- Removed direct mflux dependency from core dependencies and added it as an optional installation in the README. - Implemented checks in CLI and server code to ensure mflux is available when image generation or editing features are requested. - Updated error handling to provide installation hints for mflux when it's not available.
…ctions - Removed the direct mflux dependency from pyproject.toml. - Updated README to clarify that `mlx-openai-server[image]` is not available yet and provided alternative installation commands for mflux and the server from GitHub. - Changed pip commands to include 'uv' for better clarity in usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: make mflux optional so PyPI uploads succeed
PyPI rejects packages that declare direct URL dependencies (e.g.
mflux @ git+https://...) in published metadata. This change:mfluxfromproject.dependenciesso the sdist/wheel can be uploaded to PyPI.image-generationorimage-editis used without mflux installed, they raise a clear error with an install hint.uv pip install mlx-openai-serverthen optionaluv pip install git+https://github.com/cubist38/mflux.git, and note whymlx-openai-server[image]is not offered yet.imagedependency group frompyproject.toml.Image generation/editing still works when mflux is installed separately; the core package no longer depends on it so builds and PyPI uploads succeed.