Render attachments in examples tables. Closes #1173#1619
Merged
aslakhellesoy merged 4 commits intomainfrom Jun 17, 2021
Merged
Conversation
aslakhellesoy
added
⚡ enhancement
davidjgoss
reviewed
Jun 17, 2021
Contributor
There was a problem hiding this comment.
Looks good!
One query around image widths. At the moment our only constraint is:
max-width: 100%So if you have a big image (as in this example, but also common with browser screenshots) it will just go as wide as your screen and dominate the page.
Should we have a reasonable upper width limit e.g. 1200px? If so, should that be different within the examples table?
Contributor
Author
|
Is it a problem that the image takes the full width? It's collapsed by default. BTW, my change in the CCK seems to have triggered a test failure in |
Contributor
Yeah I think that's a fair point, you're opting into it. Sold! |
davidjgoss
approved these changes
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #1173.
Unexpanded:
Expanded: